Fix #14, support for Ruby back to 3.0.0 #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this by changing the Dockerfile to use
ubuntu:22.04
and running the example harness and confirming that coverage still works (it finds the crash). Ubuntu 22.04 currently uses clang14.0.0
, so we're able to say we've tested clang back a bit further now.Originally I chose calling
setup
instead ofstart
because I thought the performance characteristics would be better.setup
appears to configure, but not fully enable coverage gathering, whereasstart
does both. Since Ruzzy doesn't need the builtin coverage information (we're adding our own hook), I thought performance would be better without the unnecessary builtin coverage hooks. But, you know what they say: make it work, make it correct, make it fast. I also didn't have any benchmarks to confirm this hypothesis, so who knows how this actually affected performance 🤷