Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken: Puppeteer download URL access denied #1678

Open
schoeth opened this issue Aug 20, 2024 · 2 comments
Open

Build is broken: Puppeteer download URL access denied #1678

schoeth opened this issue Aug 20, 2024 · 2 comments

Comments

@schoeth
Copy link

schoeth commented Aug 20, 2024

Lightweight Charts™ Version: 4.1.4 - 4.2.0

Steps/code to reproduce:

A simple

npm install

gives me the following error:

lwc_build_error_1

If i comment out the following line, it works:

lwc_build_error_2

This is what the browser shows at this URL:

lwc_build_error_3

I don't know what that this URL should provide, but just in case that this URL is just restricted, pls. find another way so that everyone is able to do a build.

@illetid
Copy link
Contributor

illetid commented Aug 20, 2024

try to clean npm cache first npm cache clean --force, and in case you are not planning to run e2e tests, then as suggested in the error message set the PUPPETEER_SKIP_DOWNLOAD environment variable to true before the installing packages PUPPETEER_SKIP_DOWNLOAD=true npm install

@schoeth
Copy link
Author

schoeth commented Aug 23, 2024

Thanks for your Answer!
The reason why i consider the build as broken:
In my understanding a build in a public repository is working, if the public (esp. new users) checks out the repository, enters the documented commands, and the build will be done without errors.
But here the public will be sent knowingly over a bunch of deprecation-messages (even with memory-leak-warnings [inflight]), until the thing fails with error-messages.

So i see 3 ways to achive immediate successful builds for the public / new users:

  • put the stuff to be downloaded on a public site (as the repostory is),
  • change the "the public has to opt-out after failed with error" to "the perimitted ones have to opt-in", or
  • write the necessary opt-out commands into at least the BUILDING.md

Just my 2 cents ;)

@edew edew changed the title Build is broken Build is broken: Puppeteer download URL access denied Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants