From 57e030f87c969e41bdc1c5d39870d2a00e7c5a32 Mon Sep 17 00:00:00 2001 From: Mark Silverwood Date: Thu, 29 Jun 2023 20:33:39 +0100 Subject: [PATCH] improve / fix computeFiniteResult method Whoops... the function now does what it says it does, even though the old logic was actually fine for the current requirement --- src/model/price-range-impl.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/model/price-range-impl.ts b/src/model/price-range-impl.ts index c746f1a380..e11ccb31b5 100644 --- a/src/model/price-range-impl.ts +++ b/src/model/price-range-impl.ts @@ -14,10 +14,10 @@ function computeFiniteResult( ): number { const firstFinite = Number.isFinite(valueOne); return firstFinite && Number.isFinite(valueTwo) - ? ensureFiniteWithFallback(method(valueOne, valueTwo), fallback) + ? method(valueOne, valueTwo) : firstFinite ? valueOne - : valueTwo; + : ensureFiniteWithFallback(valueTwo, fallback); } export class PriceRangeImpl {