Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remember login #22

Open
ninioe opened this issue Sep 30, 2016 · 4 comments
Open

Add remember login #22

ninioe opened this issue Sep 30, 2016 · 4 comments

Comments

@ninioe
Copy link

ninioe commented Sep 30, 2016

Remember login is missing

Thanks
Erez

@tananaev
Copy link
Member

It should automatically remember credentials like in Android app.

@ninioe
Copy link
Author

ninioe commented Sep 30, 2016

It remember the server and the email but I have to enter the password again to login

@wpearse
Copy link

wpearse commented Oct 28, 2016

I imagine that it would work like this?

  1. When user logs in, credentials are stored securely by the app (iOS Keychain?)
  2. When user re-opens the app, the app should continue with previous session token
  3. If the app detects that session token has expired, then the app should automatically attempt to re-authenticate using saved credentials
  4. If saved credentials are not valid, then login screen is shown

@tananaev
Copy link
Member

The way Android app works:

  1. Credentials store in shared preferences. It's not the best option, but on Android keystore is not available on old versions and there are problems with it even on latest versions of Android. On iOS it probably makes sense to use keychain.
  2. If process is running, session will be reused.
  3. If process was killed for some reason, we create new session on start. If login is invalid, login screen is shown.

So it's very similar logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants