Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

プロジェクト名とコンテスト名の重複を禁止して、名前の上限を伸ばした #723

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

Tennessine699
Copy link
Contributor

resolves #703
resolves #712

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 27.88462% with 75 lines in your changes missing coverage. Please review.

Project coverage is 72.88%. Comparing base (49b4548) to head (0f5ef59).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/migration/v2.go 4.05% 70 Missing and 1 partial ⚠️
internal/infrastructure/repository/contest_impl.go 80.00% 1 Missing and 1 partial ⚠️
internal/infrastructure/repository/project_impl.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   72.51%   72.88%   +0.37%     
==========================================
  Files          42       42              
  Lines        3842     3843       +1     
==========================================
+ Hits         2786     2801      +15     
+ Misses        903      886      -17     
- Partials      153      156       +3     
Flag Coverage Δ
integration 72.88% <27.88%> (+0.37%) ⬆️
unit 72.88% <27.88%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

integration_tests/handler/project_test.go Outdated Show resolved Hide resolved
internal/infrastructure/migration/v2.go Show resolved Hide resolved
internal/infrastructure/migration/v2.go Show resolved Hide resolved
internal/infrastructure/migration/v2.go Outdated Show resolved Hide resolved
internal/infrastructure/migration/v2.go Show resolved Hide resolved
internal/infrastructure/migration/v2.go Outdated Show resolved Hide resolved
@ras0q
Copy link
Member

ras0q commented Sep 9, 2024

projectの方に投げたreviewはcontestも同様

@ras0q ras0q merged commit f9b3e3d into main Sep 9, 2024
12 of 13 checks passed
@ras0q ras0q deleted the improve/duplicate_project_name branch September 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants