Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build requirement gets removed for no apparent reason #2

Open
Dobatymo opened this issue Oct 11, 2024 · 1 comment
Open

build requirement gets removed for no apparent reason #2

Dobatymo opened this issue Oct 11, 2024 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Dobatymo
Copy link

Discussed in https://github.com/tox-dev/pyproject-fmt/discussions/265

Hi, great project!

I have the following in my pyproject file

[build-system]
requires = [
  "cython==3.0.11",
  "numpy==1.22.2; python_version<'3.9'",
  "numpy>=2; python_version>='3.9'",
  "setuptools",
]

when running pyproject-fmt==2.2.4 using pre-commit the "numpy==1.22.2; python_version<'3.9'", line gets removed. It looks like a bug.
@gaborbernat
Copy link
Member

It is, pull request welcome to fix it.

@gaborbernat gaborbernat transferred this issue from tox-dev/pyproject-fmt Oct 17, 2024
@gaborbernat gaborbernat added help wanted Extra attention is needed bug Something isn't working labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaborbernat @Dobatymo