Override default brotli compression level 11 -> 4 #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional discussion: #287
Motivation
The
brotli
crate used byasync-compression
has a default compression level of 11, which is the maximum for brotli. This causes extremely slow compression performance for many response bodies and is definitely an inappropriate compression level for dynamic content.There's currently an open issue (dropbox/rust-brotli#93) on the
brotli
crate's repo to change this default, but it hasn't happened at this time.Solution
This change adds a special case to convert a provided compression level of default to a compression level of 4, which is a reasonable default for dynamic content.