-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isSubsetWith): update isSubset for object array support #783
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
For this use case, we should create a new function called isSubsetWith(arr1, arr2, (x, y) => isEqualWith(x, y)); This approach aligns well with other functions like |
2ca4d62
to
f95262e
Compare
f95262e
to
83d8cd8
Compare
I think that makes sense. I went ahead and implemented the isSubsetWith function! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 😃
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
=======================================
Coverage 99.13% 99.14%
=======================================
Files 299 302 +3
Lines 2664 2675 +11
Branches 777 782 +5
=======================================
+ Hits 2641 2652 +11
Misses 22 22
Partials 1 1 |
close #767
I've made it so that we can use IsSubset with object arrays.
Here are the benchmark results.