Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Move test cases from lodash and validate es-toolkit/compat #235

Open
raon0211 opened this issue Jul 18, 2024 · 2 comments
Open

🚚 Move test cases from lodash and validate es-toolkit/compat #235

raon0211 opened this issue Jul 18, 2024 · 2 comments

Comments

@raon0211
Copy link
Collaborator

raon0211 commented Jul 18, 2024

What is es-toolkit/compat?

es-toolkit/compat is a compatibility layer designed to help you transition from lodash to es-toolkit. It aims for 100% compatibility with lodash.

See our compatibility docs.

Moving test cases from lodash

We need your help to move test cases from lodash to es-toolkit. Here's how you can contribute:

  1. Find a function in the "in review" stage in our compatibility docs.
  2. Migrate the corresponding test code from lodash.
  3. Run the migrated test code with vitest ./src/compat/**/*.
  4. Fix any failing test cases.
    • Add compatibility implementations if needed.
    • Example: chunk.
  5. If all tests pass, update our compatibility docs.
@dayongkr
Copy link
Contributor

dayongkr commented Jul 22, 2024

Some of additional tips

  • We can also run the migrated test code with vitest compat/**/*.
  • We have to update three compatibility docs (docs/compatibility.md, docs/ko/compatibility.md, docs/zh_hans/compatibility.md)

@dayongkr
Copy link
Contributor

dayongkr commented Oct 7, 2024

NOTE: At now, we can find the test codes in here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants