Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barby::QrCode does not implement valid? method #72

Open
Achimba opened this issue Sep 28, 2016 · 0 comments
Open

Barby::QrCode does not implement valid? method #72

Achimba opened this issue Sep 28, 2016 · 0 comments

Comments

@Achimba
Copy link

Achimba commented Sep 28, 2016

Therefore any calls to validate Barby::QrCode will always return false since this is the default value of the base class Barby::Barcode.

Reproduction:
barcode = Barby::QrCode.new('1234567890')
barcode.valid? == false

All of the other Symbologies implement valid? method. I think that QrCode should too.

@4geru 4geru mentioned this issue Oct 19, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant