Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled inline formating and empty line in code block #3787

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Aug 9, 2023

FX-4184

Description

We had two issues:

  • when an empty line was converted CodeBlock, it was not looking nice. The problem was that even if there was no text, we were appending the CodeBlock with TextNode. Empty TextNode has no height, so I added a condition to not add the empty TextNode. Instead the BR appears by default.
  • Disabling inline formatting was not working correctly as it was triggered from two places that were overlapping, so after moving it into one place it works as expected

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@TomasSlama TomasSlama self-assigned this Aug 9, 2023
@TomasSlama TomasSlama requested a review from a team August 9, 2023 08:33
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 7f34952

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TomasSlama TomasSlama changed the title Fx 4184 rte code block 8 fix: disabled inline formating and empty line in code block Aug 9, 2023
@TomasSlama TomasSlama requested a review from sashuk August 9, 2023 08:34
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 08:45 Inactive
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested manually on temploy (visual test changes helped too)!

@sashuk sashuk requested a review from a team August 9, 2023 10:24
Copy link
Contributor

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked the screenshot tests 👍

@TomasSlama TomasSlama merged commit 7f34952 into feature/code-block Aug 9, 2023
9 checks passed
@TomasSlama TomasSlama deleted the fx-4184-rte-code-block-8 branch August 9, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants