Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add xsmall and xlarge modal sizes #3786

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Aug 8, 2023

FX-4211

Description

This pull request adds two new Modal sizes – xsmall and xlarge.

How to test

Screenshots

Screenshot 2023-08-09 at 13 41 40

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Aug 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023

🦋 Changeset detected

Latest commit: 6dddd86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk force-pushed the fx-4211-align-modal-sizes-with-base branch from ba94b83 to abaf3d5 Compare August 8, 2023 19:04
@toptal-devbot toptal-devbot temporarily deployed to staging August 8, 2023 19:17 Inactive
@sashuk sashuk force-pushed the fx-4211-align-modal-sizes-with-base branch from abaf3d5 to 8be81c2 Compare August 9, 2023 11:33
@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 11:45 Inactive
@sashuk sashuk marked this pull request as ready for review August 9, 2023 11:51
@sashuk sashuk requested a review from a team August 9, 2023 11:51
@sashuk sashuk requested a review from a team August 9, 2023 11:54
@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 12:03 Inactive
Copy link

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks simple enough, it looks like the problems with testing are related to Happo being down today

@sashuk sashuk force-pushed the fx-4211-align-modal-sizes-with-base branch from db876af to 6dddd86 Compare August 9, 2023 15:10
@toptal-devbot toptal-devbot temporarily deployed to staging August 9, 2023 15:21 Inactive
@sashuk sashuk merged commit 769011c into master Aug 9, 2023
12 checks passed
@sashuk sashuk deleted the fx-4211-align-modal-sizes-with-base branch August 9, 2023 15:25
@toptal-build toptal-build mentioned this pull request Aug 9, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants