From 7c50e9dfdd7e4e9edeada03181ec6b88f06db597 Mon Sep 17 00:00:00 2001 From: Aleksandr Shumilov Date: Thu, 31 Oct 2024 10:18:19 +0000 Subject: [PATCH] Update contribution process (#4617) --- .github/workflows/handle-contribution.yml | 43 ----------------------- CONTRIBUTING.md | 8 ++--- 2 files changed, 2 insertions(+), 49 deletions(-) delete mode 100644 .github/workflows/handle-contribution.yml diff --git a/.github/workflows/handle-contribution.yml b/.github/workflows/handle-contribution.yml deleted file mode 100644 index 5181d7e04d..0000000000 --- a/.github/workflows/handle-contribution.yml +++ /dev/null @@ -1,43 +0,0 @@ -name: Handle contribution - -on: - pull_request: - types: [opened, reopened, ready_for_review] - branches: - - master - -jobs: - call-notify-jira-about-contribution: - if: ${{ github.event.pull_request.head.ref != 'changeset-release/master' }} - runs-on: ubuntu-latest - permissions: - contents: write - id-token: write - actions: write - issues: write - pull-requests: write - name: Call notify jira about contribution - steps: - - name: GSM Secrets - id: secrets_manager - uses: toptal/davinci-github-actions/gsm-secrets@v15.4.1 - with: - workload_identity_provider: ${{ secrets.IDENTITY_POOL }} - service_account: ${{ secrets.SA_IDENTITY_POOL }} - secrets_name: |- - PICASSO_JIRA_AUTOMATION_HOOK_FOR_NEW_CONTRIBUTION:toptal-ci/PICASSO_JIRA_AUTOMATION_HOOK_FOR_NEW_CONTRIBUTION - TOPTAL_DEVBOT_TOKEN:toptal-ci/TOPTAL_DEVBOT_TOKEN - - - name: Parse secrets - id: parse_secrets - uses: toptal/davinci-github-actions/expose-json-outputs@v15.4.1 - with: - json: ${{ steps.secrets_manager.outputs.secrets }} - - uses: toptal/davinci-github-actions/notify-jira-about-contribution@v15.4.1 - with: - team: frontend-experience-eng - repo: ${{ github.event.repository.name }} - pull-number: ${{ github.event.pull_request.number}} - jira-hook: ${{ steps.parse_secrets.outputs.PICASSO_JIRA_AUTOMATION_HOOK_FOR_NEW_CONTRIBUTION }} - github-token: ${{ steps.parse_secrets.outputs.TOPTAL_DEVBOT_TOKEN }} - should-notify-about-major-dependency-updates: true diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 35ee4a33c3..a587fde5d1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,7 +44,7 @@ The following is a set of guidelines for contributing to Picasso and its package Picasso is an internal company open source project — yes we just invented this approach 😄, which should help everyone inside Toptal to focus on their work and forgot about issues with design sync-up, repeating same implementations of UI/UX patterns, and follow same conventions in all FE projects. -Picasso is considered as project of everyone but on the top of that `Frontend Experience` team has ownership of all code and we are maintaining and keeping consistency and quality on highest level. +Picasso is collectively owned, so all of us maintain and keep consistency and quality on highest level. ### IMPORTANT: Design decisions @@ -54,11 +54,7 @@ We try to have everything inside `Picasso` synced with latest design proposal ca - Make sure tests pass by running `yarn test` -- When your PR is opened, `contribution` label will be added and a ticket will be created automatically with high priority on `Frontend Experience` Kanban board. It will be reviewed by the team as soon as possible. - -- You can also use `@toptal-anvil ping reviewers` to ping the reviewers back to get their approvals after resolving the stated issues. - -- In case of an emergency, ask for review in [#-frontend-exp-core](https://toptal-core.slack.com/archives/CERF5NHT3) +- You can also use `@toptal-anvil ping reviewers` to ping the reviewers back to get their approvals after resolving the stated issues ### Your first contribution