Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tchibo_cz - v datech chybí hodně produktů #2515

Open
MartinaGelnerova opened this issue Oct 8, 2024 · 5 comments · Fixed by #2587
Open

Tchibo_cz - v datech chybí hodně produktů #2515

MartinaGelnerova opened this issue Oct 8, 2024 · 5 comments · Fixed by #2587
Labels
actor bug Something isn't working

Comments

@MartinaGelnerova
Copy link
Collaborator

příklad produktů chybějících v datech:
https://www.tchibo.cz/products/402140769/mikina-s-kapuci
https://www.tchibo.cz/products/402179284/pyzamo-kvety?dim1=h399
https://www.tchibo.cz/products/402137271/divci-kalhotky-7-ks
@MartinaGelnerova MartinaGelnerova added bug Something isn't working actor labels Oct 8, 2024
@oklinov
Copy link

oklinov commented Oct 16, 2024

I'll take this one

@MartinaGelnerova
Copy link
Collaborator Author

Plus please check which originalPrice we save - we should save min30back
example: https://www.tchibo.cz/products/402145264/triko-s-dlouhym-rukavem-s-celopotiskem?dim1=n410
currentPrice 299
originalPrice250
image

@oklinov oklinov mentioned this issue Oct 31, 2024
Merged
@MartinaGelnerova
Copy link
Collaborator Author

@rarous pls merge

@MartinaGelnerova
Copy link
Collaborator Author

Works nicely, thanks @oklinov for the fix.

@MartinaGelnerova
Copy link
Collaborator Author

@oklinov can you please check this product https://www.tchibo.cz/products/402185624/termokabat-tmave-modra - there is no visible originalPrice, but I do get it in the data
correctly I should get originalPrice = null for this product
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actor bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tchibo): scrape more products from rest api oklinov/hlidac-shopu
2 participants
@oklinov @MartinaGelnerova