-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for source schema and exclude/include pattern and fix numeric type cast #28
Conversation
@toothrot remake the pr and added the spec need some help to get the spec to pass. |
Sorry for the delay, I will look at this shortly. |
No matter, thanks. |
spec/features/small_table_spec.rb
Outdated
after(:all) do | ||
PostgresToRedshift::Test.test_connection.exec(%q[DROP TABLE IF EXISTS "p2r_integration";]) | ||
PostgresToRedshift::Test.test_target_connection.exec(%q[DROP TABLE IF EXISTS "p2r_integration";]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove empty line here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
README.md
Outdated
export S3_DATABASE_EXPORT_ID='yourid' | ||
export S3_DATABASE_EXPORT_KEY='yourkey' | ||
export S3_DATABASE_EXPORT_BUCKET='some-bucket-to-use' | ||
export DROP_TABLE_BEFORE_CREATE = true | ||
export POSTGRES_TO_REDSHIFT_EXCLUDE_TABLE_PATTERN = 'table-pattern-to-exclude1,table-pattern-to-exclude2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe comment here that all tables are included by default?
README.md
Outdated
export S3_DATABASE_EXPORT_ID='yourid' | ||
export S3_DATABASE_EXPORT_KEY='yourkey' | ||
export S3_DATABASE_EXPORT_BUCKET='some-bucket-to-use' | ||
export DROP_TABLE_BEFORE_CREATE = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also worth mentioning that this is false by default
```bash | ||
export POSTGRES_TO_REDSHIFT_SOURCE_URI='postgres://username:password@host:port/database-name' | ||
export POSTGRES_TO_REDSHIFT_TARGET_URI='postgres://username:password@host:port/database-name' | ||
export POSTGRES_TO_REDSHIFT_TARGET_SCHEMA='testing-data' | ||
export POSTGRES_TO_REDSHIFT_SOURCE_SCHEMA='testing-data' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning that this is 'public' by default
@toothrot just updated the readme added a bunch of notes |
@dingn1 The env var docs you added include spaces between export DROP_TABLE_BEFORE_CREATE = true Should be export DROP_TABLE_BEFORE_CREATE=true |
@toothrot bump |
Added the ability to specify source schema.Also added a way to only run for certain tables and only exclude certain tables. also fixed #26