Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config parameters to init paramters #114

Open
lukecyca opened this issue Oct 19, 2020 · 0 comments
Open

Move config parameters to init paramters #114

lukecyca opened this issue Oct 19, 2020 · 0 comments

Comments

@lukecyca
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The only way to configure this library is through Kconfig parameters. This is inconvenient if the application code needs to choose these parameters at runtime. This most obvious example is setting the SSID to something device-specific, which is important it there are multiple devices requiring provisioning.

Describe the solution you'd like
I would like DEFAULT_AP_SSID, DEFAULT_HOSTNAME, and possibly some others removed from Kconfig and passed to wifi_manager_start().

Describe alternatives you've considered
I could edit wifi_manager.h, but that still doesn't allow setting these names dynamically with device-specific identifiers. I could edit the library and maintain a fork, but I prefer to fix this upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant