Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak: Allow setting margin-bottom on custom typography targets #616

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Tweak: Allow setting margin-bottom on custom typography targets #616

merged 1 commit into from
Jul 8, 2024

Conversation

frzsombor
Copy link
Contributor

Closes: #615

@iansvo iansvo changed the base branch from master to release/3.5.0 July 8, 2024 17:30
@iansvo iansvo added this to the 3.5.0 milestone Jul 8, 2024
@iansvo
Copy link
Collaborator

iansvo commented Jul 8, 2024

@frzsombor Thanks for your PR. I'm including this in the 3.5.0 release as it's a very simple change. I tested it and it seems to work as expected.

iansvo
iansvo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@iansvo iansvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, change works as expected.

@iansvo iansvo merged commit faab7cd into tomusborne:release/3.5.0 Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansvo iansvo iansvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Allow setting margin-bottom on custom typography targets
2 participants
@frzsombor @iansvo