Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance improvements do not lead to patch version bump #24

Open
hannesvanhove-tomtom opened this issue Aug 2, 2023 · 1 comment
Open

performance improvements do not lead to patch version bump #24

hannesvanhove-tomtom opened this issue Aug 2, 2023 · 1 comment

Comments

@hannesvanhove-tomtom
Copy link

Performance improvements are currently not part of the version bump while it could be beneficial to bump it as a patch version.
@muggenhor
Copy link
Collaborator

muggenhor commented Aug 2, 2023 •
edited
Loading

Feel free to create a PR to make this configurable. The final check is in commisery/commit.py:296-297. You'll want to make it accessible configurable through the CLI and also via the Hopic template (which itself invokes the CLI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@muggenhor @hannesvanhove-tomtom