Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No release on new project where no initial version tag is present #226

Open
hannesvanhove-tomtom opened this issue Mar 9, 2023 · 1 comment

Comments

@hannesvanhove-tomtom
Copy link

We integrated commisery starting from the second or third pull request without any prior releases. A PR that contained a feat: message was marked for a minor bump but the bump action itself did not do this and gave a warning: ⚠️ No matching SemVer tags found.

It seems that it would require an initial tag with a version to work, instead I was expecting that it would create the first release 0.1.0

@jstmlr
Copy link
Collaborator

jstmlr commented Mar 9, 2023

We decided a few years ago on the original tomtom-international/commisery, that the risk of getting an erroneous tag list due to network issues and dirty workspaces was too large to implement such behavior. During development of commisery-action, along with a lot of functional and behavioral details, this reasoning was adopted from commisery as well.

However, since commisery-action functions fully independent of checkouts/workspaces, that risk is now negligible, and the main risk remaining is people mistakenly starting the /bump action with an incorrect prefix (and starting a new version series), which we now deem acceptable.

We'll pick this up soon and see if we can mitigate the most obvious risks.
Thanks for reporting this and getting the conversation going again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants