Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issie DOM memory leak (now fixed) #463

Open
tomcl opened this issue Aug 14, 2024 · 0 comments
Open

Issie DOM memory leak (now fixed) #463

tomcl opened this issue Aug 14, 2024 · 0 comments

Comments

@tomcl
Copy link
Owner

tomcl commented Aug 14, 2024

Describe the bug

Issie pre-5.1.0 had a memory leak that caused slowdown and then crashing after long use. The leakage scales with edited sheet size so when editing a large sheet this slowdown happens after < 5 minutes.

Cause and Solution

  • This went away after refactoring the draw block not to use a mutable reference to the last created DOM to manage scrolling.
  • In the process of fixing this a lot of refactoring was done to reduce DOM listener and message dependence on model.

However - for the record - this was not a bug in the Issie code but introduced in a later release of React 17.

facebook/react#27892

We should therefore find that the old code would also work if we could upgrade to React 18. This depends on upgrading to Elmish v4 which is on the TODO list but not urgent. React 18 has significant differences from 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant