Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does the unique option work? #48

Open
AndrewTriesToCode opened this issue Feb 1, 2021 · 6 comments
Open

does the unique option work? #48

AndrewTriesToCode opened this issue Feb 1, 2021 · 6 comments
Assignees

Comments

@AndrewTriesToCode
Copy link

Trying the unique option and I don't see any difference in the output. Thanks!

@tomchavakis
Copy link
Owner

Hi @AndrewTriesToCode ,

Thank you for the issue. I've created a unit test to check if the unique functionality is broken and it looks ok.
PR: https://github.com/tomchavakis/nuget-license/pull/52/files

Moreover, I've tested a project with the same library and the unique flag just return the library once.
Example:

dotnet-project-licenses -i projectFolder -u

Could you please tell me more about it or an example?
Thanks!

@umairjadoon
Copy link
Collaborator

umairjadoon commented Apr 26, 2021

Does unique works only when name and version both are unique? I have the following example output for one of the projects

 System.Xml.ReaderWriter                               | 4.3.0                                          | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.ReaderWriter                               | 4.0.11                                         | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.ReaderWriter                               | 4.0.10                                         | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.XDocument                                  | 4.3.0                                          | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.XDocument                                  | 4.0.11                                         | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.XmlDocument                                | 4.0.1                                          | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.XmlDocument                                | 4.3.0                                          | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770                         |
 | System.Xml.XmlDocument                                | 4.0.0                                          | MS-EULA         | http://go.microsoft.com/fwlink/?LinkId=329770

@tomchavakis tomchavakis self-assigned this Apr 26, 2021
@tomchavakis
Copy link
Owner

Hi @umairjadoon,

If the unique flag is active, then the tool groups the libraries by package name and the package version. From your output, I can see that both are different. If you need this functionality, I can add a new parameter to the cli tool in order to group by name only. What do you think?

@umairjadoon
Copy link
Collaborator

Hi @tomchavakis thanks alot for reply. Your tool helped a great deal and i think that would be great to have group by name possibility. Also is it possible to get the packages per individual project in solution? or when one uses list of projects in json file then per project separation list?

@tomchavakis tomchavakis reopened this Apr 27, 2021
@tomchavakis
Copy link
Owner

Hi @umairjadoon,

Thanks for the reply and your kind words. I would try to update the unique functionality asap as you proposed.

@tomchavakis
Copy link
Owner

Hi @umairjadoon,

You can check the new functionality at the next PR
#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants