Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When "brotli" is disabled and "gzip" is enabled, responses are not compressed #270

Open
fleabitdev opened this issue Jan 21, 2023 · 0 comments
Labels

Comments

@fleabitdev
Copy link

Version: 3.6.1

To reproduce: Enable the "gzip" feaure, disable the "brotli" feature, and serve a text/plain document using rouille::content_encoding::apply(). Access that document using a browser which accepts the encodings gzip and br.

Expected behaviour: The response should be gzip-compressed.

Observed behaviour: rouille::content_encoding::apply() prioritises brotli encoding over gzip encoding, even when the "brotli" feature is disabled. Under those circumstances, the brotli() function in that module is stubbed out, so the response is not compressed.

@bradfier bradfier added the bug label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants