Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request::remove_prefix behaviour is surprising #208

Open
Diggsey opened this issue Mar 6, 2019 · 1 comment
Open

Request::remove_prefix behaviour is surprising #208

Diggsey opened this issue Mar 6, 2019 · 1 comment

Comments

@Diggsey
Copy link
Contributor

Diggsey commented Mar 6, 2019

The example for remove_prefix shows it being used to route /static. However, the implementation does not require that the prefix be a complete path segment, so URLs like /static-foo, /statically etc. will also be matched.

IMO the function should only succeed for whole path segments.
@tomaka
Copy link
Owner

tomaka commented Jun 8, 2019

IMO the function should only succeed for whole path segments.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Diggsey @tomaka