Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/CI: library -Wno-error escape is too coarse-grained #472

Open
ppannuto opened this issue Oct 29, 2024 · 0 comments
Open

build/CI: library -Wno-error escape is too coarse-grained #472

ppannuto opened this issue Oct 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ppannuto
Copy link
Member

libtock-c is fairly pedantic about warnings. When we build external libraries, we relax this by no longer error'ing on warnings (i.e.

# Avoid failing in CI due to warnings in the library.
CPPFLAGS_$(LIBNAME) += -Wno-error
). While this is fine/necessary for the library code itself, it also ignores warnings in our interface code, which in practice lets things like #471 slip through.

We should ideally only allow warnings on actual third-party code, and enforce our stronger checks on our interface code.

@ppannuto ppannuto added the enhancement New feature or request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant