Refactor!: treat Nullable as an arg instead of a DataType.TYPE #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation behind this PR is that nullable types are awkward to deal with: to access the wrapped type, one has to always do
data_type.thisinstead of justdata_type, meaning that the concept of nullability "leaks" into third-party code that may not care at all about it.This refactor encodes nullability as an arg in
DataType, so that it's less intrusive. Now, it will be taken into account when e.g. comparing data types (which can be optionally turned off by usingis_type), and when roundtripping CH code.