Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(mysql): convert VARCHAR without size to TEXT for DDLs #4092

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

georgesittas
Copy link
Collaborator

@georgesittas georgesittas commented Sep 9, 2024

VARCHAR without a size is invalid in MySQL. This is not handled today, resulting in DDLs that can contain VARCHAR types when transpiling SQL towards MySQL. This PR addresses this issue.

Context: https://tobiko-data.slack.com/archives/C044BRE5W4S/p1725866958110369

@georgesittas georgesittas merged commit 1e02c02 into main Sep 9, 2024
6 checks passed
@georgesittas georgesittas deleted the jo/mysql_varchar_fix branch September 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants