Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: various endpoint car name faulty #244

Closed
tobiasehlert opened this issue Sep 22, 2023 · 0 comments · Fixed by #245
Closed

Bug: various endpoint car name faulty #244

tobiasehlert opened this issue Sep 22, 2023 · 0 comments · Fixed by #245
Assignees
Labels
bug Something isn't working

Comments

@tobiasehlert
Copy link
Owner

tobiasehlert commented Sep 22, 2023

The status, update and more endpoints are not returning car_name correct.
The cars endpoint is returning correct, so NullString is working as expected there.

example URL:

/api/v1/cars/1/status

example JSON response:

{
    "data": {
        "car": {
            "car_id": 1,
            "car_name": {
                "String": "",
                "Valid": false
            }
        },

expected JSON response:

{
    "data": {
        "car": {
            "car_id": 1,
            "car_name":""
        },

rel #242

@tobiasehlert tobiasehlert added the bug Something isn't working label Sep 22, 2023
@tobiasehlert tobiasehlert self-assigned this Sep 22, 2023
@tobiasehlert tobiasehlert changed the title Bug: status endpoint car name faulty Bug: status and updates endpoint car name faulty Sep 22, 2023
@tobiasehlert tobiasehlert changed the title Bug: status and updates endpoint car name faulty Bug: various endpoint car name faulty Sep 22, 2023
@tobiasehlert tobiasehlert linked a pull request Sep 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant