Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lrnr_glm family argument #227

Open
kmishra9 opened this issue Aug 7, 2019 · 1 comment
Open

Lrnr_glm family argument #227

kmishra9 opened this issue Aug 7, 2019 · 1 comment
Assignees

Comments

@kmishra9
Copy link

kmishra9 commented Aug 7, 2019

Hey there,

A quick suggestion would be to either

  1. mention that Lrnr_glm$train() calls glm.fit(), rather than glm() or
  2. mention that the family = ... argument accepted by glm.fit() and thus sl3 is required to be "the result of a call to a family function" (i.e. guassian()). When I tried to use family="gaussian" and family=guassian in a lrnr_glm$train() call, I ran into an error that took some time to hunt down.
> lrnr_glm = make_learner(learner_class = Lrnr_glm, family = "gaussian")
> lrnr_glm$train(train_task)
Failed on Lrnr_glm_TRUE_gaussian
Error: $ operator is invalid for atomic vectors

and

> lrnr_glm = make_learner(learner_class = Lrnr_glm, family = gaussian)
> lrnr_glm$train(train_task)
Failed on Lrnr_glm_TRUE
Error in args$family$family : object of type 'closure' is not subsettable
@kmishra9 kmishra9 changed the title Lrnr_glm family Lrnr_glm family argument Aug 7, 2019
@jeremyrcoyle jeremyrcoyle self-assigned this Aug 7, 2019
@jeremyrcoyle
Copy link
Collaborator

Also making a note to add language indicating that by default family is set automatically from the outcome variable type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants