-
Notifications
You must be signed in to change notification settings - Fork 16
/
.perlcriticrc
332 lines (253 loc) · 8.56 KB
/
.perlcriticrc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
# My Perl Critic configuration
only = 1
force = 0
severity = 2
top = 50
# coloration
color-severity-highest = bold red underline
color-severity-high = bold magenta
color-severity-medium = blue
color-severity-low =
color-severity-lowest =
######## Explicit modules to include
# should be almost everything in
# BuiltinFunctions
# CodeLayout
# InputOutput
# Modules
# Variables
# and in themes
# pbp
# core
# exceptions are commented out with reasons
[Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep]
# themes: certrec core pbp performance
severity = 2
[Perl::Critic::Policy::BuiltinFunctions::ProhibitComplexMappings]
# themes: complexity core maintenance pbp
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::ProhibitLvalueSubstr]
# themes: core maintenance pbp
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::ProhibitReverseSortBlock]
# themes: core cosmetic pbp
severity = 1
[Perl::Critic::Policy::BuiltinFunctions::ProhibitShiftRef]
# themes: bugs core tests
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::ProhibitSleepViaSelect]
# themes: bugs core pbp
severity = 5
[Perl::Critic::Policy::BuiltinFunctions::ProhibitStringyEval]
# themes: bugs certrule core pbp
severity = 5
[Perl::Critic::Policy::BuiltinFunctions::ProhibitStringySplit]
# themes: certrule core cosmetic pbp
severity = 2
[Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalCan]
# themes: certrule core maintenance
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::ProhibitUniversalIsa]
# themes: certrule core maintenance
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::ProhibitUselessTopic]
# themes: core
severity = 2
[Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidGrep]
# themes: core maintenance
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::ProhibitVoidMap]
# themes: core maintenance
severity = 3
[Perl::Critic::Policy::BuiltinFunctions::RequireBlockGrep]
# themes: bugs core pbp
severity = 4
[Perl::Critic::Policy::BuiltinFunctions::RequireBlockMap]
# themes: bugs core pbp
severity = 4
[Perl::Critic::Policy::BuiltinFunctions::RequireGlobFunction]
# themes: bugs core pbp
severity = 5
[Perl::Critic::Policy::BuiltinFunctions::RequireSimpleSortBlock]
# themes: complexity core maintenance pbp
severity = 3
[Perl::Critic::Policy::ClassHierarchies::ProhibitAutoloading]
# themes: core maintenance pbp
severity = 5
[Perl::Critic::Policy::CodeLayout::ProhibitHardTabs]
# themes: core cosmetic pbp
severity = 1
allow_leading_tabs = 1
[Perl::Critic::Policy::CodeLayout::ProhibitParensWithBuiltins]
# themes: core cosmetic pbp
severity = 1
[Perl::Critic::Policy::CodeLayout::ProhibitQuotedWordLists]
# themes: core cosmetic
severity = 2
[Perl::Critic::Policy::CodeLayout::ProhibitTrailingWhitespace]
# themes: core maintenance
severity = 1
[Perl::Critic::Policy::CodeLayout::RequireConsistentNewlines]
# themes: bugs core
severity = 4
[Perl::Critic::Policy::CodeLayout::RequireTidyCode]
# themes: core cosmetic pbp
severity = 1
[Perl::Critic::Policy::CodeLayout::RequireTrailingCommas]
# themes: core cosmetic pbp
severity = 1
[Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls]
# themes: core cosmetic pbp
allow = unless if
severity = 2
[Perl::Critic::Policy::InputOutput::ProhibitBacktickOperators]
# themes: core maintenance
severity = 3
[Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles]
# themes: bugs certrec core pbp
severity = 5
[Perl::Critic::Policy::InputOutput::ProhibitExplicitStdin]
# themes: core maintenance pbp
severity = 4
[Perl::Critic::Policy::InputOutput::ProhibitInteractiveTest]
# themes: bugs certrule core pbp
severity = 5
[Perl::Critic::Policy::InputOutput::ProhibitJoinedReadline]
# themes: core pbp performance
severity = 3
[Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect]
# themes: bugs certrule core pbp
severity = 4
[Perl::Critic::Policy::InputOutput::ProhibitReadlineInForLoop]
# themes: bugs core pbp
severity = 4
[Perl::Critic::Policy::InputOutput::ProhibitTwoArgOpen]
# themes: bugs certrule core pbp security
severity = 5
[Perl::Critic::Policy::InputOutput::RequireBracedFileHandleWithPrint]
# themes: core cosmetic pbp
severity = 1
[Perl::Critic::Policy::InputOutput::RequireBriefOpen]
# themes: core maintenance pbp
severity = 4
[Perl::Critic::Policy::InputOutput::RequireCheckedClose]
# themes: certrule core maintenance
severity = 2
[Perl::Critic::Policy::InputOutput::RequireCheckedOpen]
# themes: certrule core maintenance
severity = 3
[Perl::Critic::Policy::InputOutput::RequireCheckedSyscalls]
# themes: certrule core maintenance
severity = 1
[Perl::Critic::Policy::InputOutput::RequireEncodingWithUTF8Layer]
# themes: bugs core security
severity = 5
[Perl::Critic::Policy::Miscellanea::ProhibitTies]
# themes: core maintenance pbp
severity = 2
[Perl::Critic::Policy::Modules::ProhibitAutomaticExportation]
# themes: bugs core
severity = 4
[Perl::Critic::Policy::Modules::ProhibitConditionalUseStatements]
# themes: bugs core
severity = 3
[Perl::Critic::Policy::Modules::ProhibitEvilModules]
# themes: bugs certrule core
severity = 5
# [Perl::Critic::Policy::Modules::ProhibitExcessMainComplexity]
# some of the scripts are old and definitely complex
# but I don't have time to rewrite them at the moment
# themes: complexity core maintenance
# severity = 3
# [Perl::Critic::Policy::Modules::ProhibitMultiplePackages]
# I have a few packages that are NEVER used outside of its
# parent, so moving into separate module doesn't really make sense
# themes: bugs core
# severity = 4
[Perl::Critic::Policy::Modules::RequireBarewordIncludes]
# themes: core portability
severity = 5
[Perl::Critic::Policy::Modules::RequireEndWithOne]
# themes: bugs certrule core pbp
severity = 4
[Perl::Critic::Policy::Modules::RequireExplicitPackage]
# themes: bugs core
severity = 4
[Perl::Critic::Policy::Modules::RequireFilenameMatchesPackage]
# themes: bugs core
severity = 5
[Perl::Critic::Policy::Modules::RequireNoMatchVarsWithUseEnglish]
# themes: core performance
severity = 2
[Perl::Critic::Policy::Modules::RequireVersionVar]
# themes: core pbp readability
severity = 2
# [Perl::Critic::Policy::NamingConventions::ProhibitAmbiguousNames]
# themes: core maintenance pbp
# default = last set left right no abstract contract record second close
forbid = no abstract contract record close
severity = 3
[Perl::Critic::Policy::References::ProhibitDoubleSigils]
# themes: core cosmetic pbp
severity = 2
[Perl::Critic::Policy::RegularExpressions::ProhibitUnusedCapture]
# themes: core maintenance pbp
severity = 3
[Perl::Critic::Policy::RegularExpressions::RequireExtendedFormatting]
# themes: core maintenance pbp
severity = 3
minimum_regex_length_to_complain_about = 10
[Perl::Critic::Policy::ValuesAndExpressions::ProhibitEmptyQuotes]
# themes: core cosmetic pbp
severity = 2
[Perl::Critic::Policy::ValuesAndExpressions::ProhibitLeadingZeros]
# themes: bugs certrec core pbp
severity = 5
[Perl::Critic::Policy::ValuesAndExpressions::ProhibitMismatchedOperators]
# themes: bugs certrule core
severity = 3
[Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators]
# themes: bugs certrec core pbp
severity = 4
[Perl::Critic::Policy::Variables::ProhibitAugmentedAssignmentInDeclaration]
# themes: bugs core
severity = 4
[Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations]
# themes: bugs core
severity = 5
[Perl::Critic::Policy::Variables::ProhibitLocalVars]
# themes: core maintenance pbp
severity = 2
[Perl::Critic::Policy::Variables::ProhibitMatchVars]
# themes: core pbp performance
severity = 4
[Perl::Critic::Policy::Variables::ProhibitPackageVars]
# themes: core maintenance pbp
severity = 3
[Perl::Critic::Policy::Variables::ProhibitPerl4PackageNames]
# themes: certrec core maintenance
severity = 2
[Perl::Critic::Policy::Variables::ProhibitPunctuationVars]
# themes: core cosmetic pbp
severity = 2
[Perl::Critic::Policy::Variables::ProhibitReusedNames]
# themes: bugs core
severity = 3
[Perl::Critic::Policy::Variables::ProhibitUnusedVariables]
# themes: certrec core maintenance
severity = 3
[Perl::Critic::Policy::Variables::ProtectPrivateVars]
# themes: certrule core maintenance
severity = 3
[Perl::Critic::Policy::Variables::RequireInitializationForLocalVars]
# themes: bugs certrec core pbp
severity = 3
[Perl::Critic::Policy::Variables::RequireLexicalLoopIterators]
# themes: bugs certrec core pbp
severity = 5
[Perl::Critic::Policy::Variables::RequireLocalizedPunctuationVars]
# themes: bugs certrec core pbp
severity = 4
[Perl::Critic::Policy::Variables::RequireNegativeIndices]
# themes: core maintenance pbp
severity = 4