Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: namespace import referencing via value aliases #965

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Conversation

tivac
Copy link
Owner

@tivac tivac commented Aug 7, 2023

Description

Updating the internal value mapping after handling imported @values.

Motivation and Context

Fixes #964

How Has This Been Tested?

I added a test that fails before the fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added a changeset for my change.

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2023

🦋 Changeset detected

Latest commit: 5dedc7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@modular-css/processor Patch
@modular-css/browserify Patch
@modular-css/cli Patch
@modular-css/css-to-js Patch
@modular-css/glob Patch
@modular-css/postcss Patch
@modular-css/rollup Patch
@modular-css/svelte Patch
@modular-css/vite Patch
@modular-css/webpack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented Aug 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for m-css ready!

Name Link
🔨 Latest commit 5dedc7e
🔍 Latest deploy log https://app.netlify.com/sites/m-css/deploys/64d18500a85dea0008abc703
😎 Deploy Preview https://deploy-preview-965--m-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (880b5a2) 99.72% compared to head (5dedc7e) 99.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          37       37           
  Lines        1433     1438    +5     
  Branches      235      236    +1     
=======================================
+ Hits         1429     1434    +5     
  Misses          4        4           
Files Changed Coverage Δ
packages/processor/plugins/values-import.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tivac tivac merged commit edbbe96 into main Aug 8, 2023
12 checks passed
@tivac tivac deleted the issue-964 branch August 8, 2023 01:13
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@value aliases to namespaced values are lost
1 participant