Feat: remove wild DeepL keys #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
It's okay to remove the wild key, but it's not friendly for those users who can't use the official key. Can you add a DeepL custom endpoint option so that users can use DeepL third-party services, such as DeepLX? |
tisfeng
reviewed
Apr 4, 2024
tisfeng
reviewed
Apr 4, 2024
|
@HernandoR I have added Custom DeepL API URL, I have done all the work related to it, your commit code will cause conflict, please revert it. |
tisfeng
reviewed
Apr 13, 2024
tisfeng
force-pushed
the
feat-remove-wild-DeepL-keys
branch
from
ecccab2
to
e7024b7
Compare
tisfeng
approved these changes
Apr 13, 2024
tisfeng
added a commit
that referenced
this pull request
Apr 13, 2024
* chore: remove wild DeepL support * fix: show error toast when DeepL failed * perf: remove all wild DeepL api keys * perf: do not check DeepL API key valid * feat: enable to use custom DeepL API URL * docs: update README --------- Co-authored-by: tisfeng <[email protected]>
|
Seems good to me |
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wild deepL keys from github is immoral and potentially illegal.