Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: don't use types in the global context #3917

Merged
merged 1 commit into from
Sep 19, 2023
Merged

compiler: don't use types in the global context #3917

merged 1 commit into from
Sep 19, 2023

Commits on Sep 18, 2023

  1. compiler: don't use types in the global context 

    This usually works by chance, but leads to crashes. So we should never
ever do this.

I'm pretty sure this is the crash behind this issue: #3894

It may also have caused this crash: #3874

I have a suspicion this is also behind the rather crash-prone CircleCI
jobs, that we haven't been able to find the source of. But we'll find
out soon enough once this fix is merged.

To avoid hitting this issue again in the future, I've created a PR to
remove these dangerous functions altogether from the go-llvm API:
tinygo-org/go-llvm#54
    @aykevl
    aykevl committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    81a3419 View commit details
    Browse the repository at this point in the history