Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HID Keyboard LEDs #3854

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Add support for HID Keyboard LEDs #3854

merged 1 commit into from
Aug 7, 2023

Conversation

Unrud
Copy link
Contributor

@Unrud Unrud commented Aug 5, 2023

  • Receive HID Output Report with Num/Caps/Scroll Lock state
  • Add methods to Keyboard to read the LED state

@Unrud Unrud force-pushed the feature/usb-hid-keyboard-led branch from 96aee9d to 60d5fe1 Compare August 5, 2023 14:20
@deadprogram deadprogram requested a review from sago35 August 5, 2023 21:08
sago35
sago35 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@sago35 sago35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution

@deadprogram
Copy link
Member

Thank you for the code @Unrud and to @sago35 for review. Now merging.

@deadprogram deadprogram merged commit 0ef86e1 into tinygo-org:dev Aug 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sago35 sago35 sago35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Unrud @deadprogram @sago35