Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts shouldn't need network requests to filter their own data #224

Open
timwis opened this issue Apr 20, 2018 · 2 comments
Open

Charts shouldn't need network requests to filter their own data #224

timwis opened this issue Apr 20, 2018 · 2 comments
Labels

Comments

@timwis
Copy link
Owner

timwis commented Apr 20, 2018

When you select a bar, the chart you selected filters itself to only show that bar. Maybe we could just use highlighting from #222 to save a network request. And the filtered <path> on the DateTime chart doesn't quite align fully with the initial line anyway. I think v1 behaves this way for pie charts.

@timwis timwis added the v2 label Apr 20, 2018
@timwis
Copy link
Owner Author

timwis commented Apr 26, 2018

I've got DateTime not filtering itself, and instead using a <clipPath> to only show the selected range, but the tooltip still shows filtered amounts for the whole chart (when another filter is active). So a better wording of this issue would be that charts shouldn't make network requests to filter themselves.

@timwis timwis changed the title Maybe charts shouldn't filter themselves Charts shouldn't need network requests to filter their own data Apr 26, 2018
@timwis
Copy link
Owner Author

timwis commented Apr 27, 2018

Note that the table component will need a network request to filter itself (say, by searching).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant