Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove client-side downloads limit check on upload #168

Open
shvchk opened this issue Sep 7, 2023 · 3 comments
Open

Remove client-side downloads limit check on upload #168

shvchk opened this issue Sep 7, 2023 · 3 comments

Comments

@shvchk
Copy link

shvchk commented Sep 7, 2023 •
edited
Loading

When trying to set downloads limit to more than 20 on upload, ffsend returns an error: The downloads limit must be one of: 1, 2, 3, 4, 5, 20, so we have to use --force. At the same time, most Send instances have downloads limit more than 20. This limit is enforced server-side anyway, so I don't really see a point in enforcing it with a limited set of options on the client.
@shvchk shvchk changed the title Remove client-side download limit check Remove client-side download limit check on upload Sep 7, 2023
@shvchk shvchk changed the title Remove client-side download limit check on upload Remove client-side downloads limit check on upload Sep 7, 2023
@timvisee
Copy link
Owner

timvisee commented Sep 7, 2023

What do you think about downgrading this to a warning?

@shvchk
Copy link
Author

shvchk commented Sep 7, 2023

sounds good 🙂

@parasiteoflife
Copy link

please do the same for sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timvisee @shvchk @parasiteoflife