pd-ctl: reduce duplicate params in grant hot region scheduler #8673
Conversation
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8673 +/- ##
==========================================
+ Coverage 77.50% 77.54% +0.03%
==========================================
Files 474 474
Lines 62311 62355 +44
==========================================
+ Hits 48297 48353 +56
+ Misses 10448 10436 -12
Partials 3566 3566
Flags with carried forward coverage won't be shown. Click here to find out more. |
| }) | ||
|
|
||
| // use duplicate store id | ||
| checkSchedulerCommand(re, cmd, pdAddr, []string{"-u", pdAddr, "scheduler", "add", "grant-hot-region-scheduler", "3", "1,2,3"}, map[string]bool{ |
There was a problem hiding this comment.
Do we need to check
testutil.Eventually(re, func() bool {
mustExec(re, cmd, []string{"-u", pdAddr, "scheduler", "config", "grant-hot-region-scheduler"}, &conf3)
return compareGrantHotRegionSchedulerConfig(expected3, conf3)
})after adding grant-hot-region-scheduler?
There was a problem hiding this comment.
Do you mean L658-L661?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: lhy1024 <[email protected]>
lhy1024
changed the title
What problem does this PR solve?
Issue Number: Close #8672
What is changed and how does it work?
Check List
Tests
Release note