pkg: delete config when QPS and concurrency are both deleted #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
rleungx
force-pushed
the
case-delete
branch
from
514d35a
to
d03c2f1
Compare
ti-chi-bot
bot
added
size/XS
rleungx
changed the title
rleungx
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8653 +/- ##
==========================================
- Coverage 77.54% 77.50% -0.04%
==========================================
Files 474 474
Lines 62359 62352 -7
==========================================
- Hits 48358 48328 -30
- Misses 10441 10446 +5
- Partials 3560 3578 +18
Flags with carried forward coverage won't be shown. Click here to find out more. |
lhy1024
reviewed
Sep 24, 2024
pkg/ratelimit/option.go
Outdated
| return lim.(*limiter).updateDimensionConfig(cfg) | ||
| status := lim.(*limiter).updateDimensionConfig(cfg) | ||
| if status&QPSDeleted != 0 && status&ConcurrencyDeleted != 0 { | ||
| l.limiters.Delete(label) |
There was a problem hiding this comment.
What will happen if this is not removed?
There was a problem hiding this comment.
leave a config in output that is meaningless
lhy1024
approved these changes
Sep 25, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
okJiang
approved these changes
Sep 26, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Signed-off-by: Ryan Leung <[email protected]>
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
case-delete
branch
from
e4f7c17
to
cf11dfe
Compare
ti-chi-bot
bot
added
size/XL
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
case-delete
branch
from
ef49704
to
d812f62
Compare
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
case-delete
branch
from
2a5e80d
to
87b93a7
Compare
Signed-off-by: Ryan Leung <[email protected]>
rleungx
force-pushed
the
case-delete
branch
from
2aa580b
to
c959207
Compare
okJiang
reviewed
Sep 29, 2024
| @@ -89,6 +83,6 @@ func InitLimiter() Option { | |||
| return InAllowList | |||
| } | |||
| l.limiters.LoadOrStore(label, newLimiter()) | |||
| return ConcurrencyChanged | |||
| return LimiterNotChanged | |||
There was a problem hiding this comment.
Has there been a change here, as expected?
There was a problem hiding this comment.
Yes, the limit is not changed when we initialize the limiter.
| if limit <= eps || burst < 1 { | ||
| l.rate = nil | ||
| if l.isEmpty() { | ||
| return LimiterDeleted |
There was a problem hiding this comment.
Should this be LimiterNoChanged?
There was a problem hiding this comment.
No, LimiterDeleted indicates that we should remove the corresponding label from the config.
lhy1024
approved these changes
Sep 29, 2024
okJiang
approved these changes
Sep 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #4373.
What is changed and how does it work?
Check List
Tests
Release note