Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add some comments to exported function, part 3 of enable revive.exported #8507

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Aug 8, 2024

What problem does this PR solve?

Issue Number: Ref #8458

What is changed and how does it work?

add comments for exported and update some exported-function to unexported

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2024
pkg/schedule/schedulers/balance_leader.go Outdated Show resolved Hide resolved
pkg/schedule/prepare_checker.go Outdated Show resolved Hide resolved
pkg/schedule/checker/checker_controller.go Outdated Show resolved Hide resolved
pkg/mcs/scheduling/server/apis/v1/api.go Outdated Show resolved Hide resolved
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 79.67480% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.40%. Comparing base (7741924) to head (fa57a7c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8507   +/-   ##
=======================================
  Coverage   77.40%   77.40%           
=======================================
  Files         472      472           
  Lines       61800    61828   +28     
=======================================
+ Hits        47838    47860   +22     
- Misses      10395    10400    +5     
- Partials     3567     3568    +1     
Flag Coverage Δ
unittests 77.40% <79.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-09 08:23:34.618995937 +0000 UTC m=+599544.486095024: ☑️ agreed by rleungx.
  • 2024-08-09 08:52:18.290604158 +0000 UTC m=+601268.157703247: ☑️ agreed by HuSharp.

Signed-off-by: okJiang <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit 92adb24 into tikv:master Aug 9, 2024
25 checks passed
@okJiang okJiang deleted the exported branch August 9, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants