*: reduce unsafe usage #8482
Merged
*: reduce unsafe usage #8482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8482 +/- ##
==========================================
+ Coverage 77.30% 77.32% +0.02%
==========================================
Files 472 472
Lines 61789 61780 -9
==========================================
+ Hits 47766 47773 +7
+ Misses 10448 10441 -7
+ Partials 3575 3566 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
JmPotato
approved these changes
Aug 2, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
nolouch
reviewed
Aug 5, 2024
| @@ -2142,7 +2142,7 @@ func HexRegionKey(key []byte) []byte { | |||
| // HexRegionKeyStr converts region key to hex format. Used for formatting region in | |||
| // logs. | |||
| func HexRegionKeyStr(key []byte) string { | |||
| return typeutil.BytesToString(HexRegionKey(key)) | |||
| return string(HexRegionKey(key)) | |||
There was a problem hiding this comment.
could you refer to relative go changes?
There was a problem hiding this comment.
lhy1024
approved these changes
Aug 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #8475.
What is changed and how does it work?
With go1.22.5
Check List
Tests
Release note