Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_manager: add metrics to show resource group configuration #8478

Merged
merged 3 commits into from
Aug 8, 2024
Merged

resource_manager: add metrics to show resource group configuration #8478

merged 3 commits into from
Aug 8, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Aug 1, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8444

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    image

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (ff71512) to head (f08d4de).
Report is 58 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8478      +/-   ##
==========================================
+ Coverage   77.46%   77.50%   +0.04%     
==========================================
  Files         472      472              
  Lines       61795    61800       +5     
==========================================
+ Hits        47867    47901      +34     
+ Misses      10371    10330      -41     
- Partials     3557     3569      +12
Flag Coverage Δ
unittests 77.50% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor Author

nolouch commented Aug 6, 2024

PTAL @JmPotato @HuSharp

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 6, 2024
@nolouch
address
3654d06 
Signed-off-by: nolouch <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-06 07:55:54.798519546 +0000 UTC m=+338684.665618632: ☑️ agreed by JmPotato.
  • 2024-08-08 06:29:35.721695822 +0000 UTC m=+506305.588794907: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit 56f082d into tikv:master Aug 8, 2024
24 checks passed
@nolouch nolouch deleted the add-group-config-metrics branch August 8, 2024 08:08
@mzhang77 mzhang77 mentioned this pull request Aug 13, 2024
Closed
@nolouch
Copy link
Contributor Author

nolouch commented Sep 20, 2024

/run-cherry-picker

@nolouch nolouch added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Sep 20, 2024
@nolouch
Copy link
Contributor Author

nolouch commented Sep 20, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8638.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 20, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8639.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 20, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Sep 20, 2024
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8478
6ed5e14 
close tikv#8444

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8640.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 20, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@ti-chi-bot @nolouch
resource_manager: add metrics to show resource group configuration (#…
aa1a99c 
…8478) (#8638)

close #8444

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@ti-chi-bot @nolouch
resource_manager: add metrics to show resource group configuration (#…
b55ba77 
…8478) (#8640)

close #8444

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2024
@ti-chi-bot @nolouch
resource_manager: add metrics to show resource group configuration (#…
a0ad735 
…8478) (#8639)

close #8444

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
Co-authored-by: ShuNing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@HuSharp HuSharp HuSharp approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics about RU settings
4 participants
@nolouch @ti-chi-bot @JmPotato @HuSharp