Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-ctl: fix the output trim #8309

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4399.

What is changed and how does it work?

Fix the output trim of the pd-ctl command.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Before:

image

After:

image

Release note

None.

@JmPotato JmPotato added the component/tools Tools. label Jun 19, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2024
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (6f8286b) to head (ca7a021).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8309      +/-   ##
==========================================
- Coverage   77.40%   77.34%   -0.06%     
==========================================
  Files         470      470              
  Lines       61359    61360       +1     
==========================================
- Hits        47494    47460      -34     
- Misses      10308    10347      +39     
+ Partials     3557     3553       -4     
Flag Coverage Δ
unittests 77.34% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2024

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-19 09:39:39.708698216 +0000 UTC m=+194106.194187044: ☑️ agreed by rleungx.
  • 2024-06-19 09:59:51.623313601 +0000 UTC m=+195318.108802431: ☑️ agreed by HuSharp.

@JmPotato JmPotato removed the require-LGT1 Indicates that the PR requires an LGTM. label Jun 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9804702 into tikv:master Jun 19, 2024
22 checks passed
@JmPotato JmPotato deleted the fix_pd_ctl_output branch June 19, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/tools Tools. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants