Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/join: log detailed info when a join failure member is detected #8243

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jun 4, 2024

What problem does this PR solve?

Issue Number: ref #7983.

What is changed and how does it work?

Log the detailed info when a join failure member is detected to help troubleshoot.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx June 4, 2024 07:15
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.33%. Comparing base (a929a54) to head (0539cd2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8243      +/-   ##
==========================================
- Coverage   77.34%   77.33%   -0.01%     
==========================================
  Files         471      471              
  Lines       61369    61377       +8     
==========================================
+ Hits        47463    47464       +1     
- Misses      10338    10357      +19     
+ Partials     3568     3556      -12     
Flag Coverage Δ
unittests 77.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2024
@HuSharp
Copy link
Member

HuSharp commented Jun 4, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 0539cd2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2024

@niubell: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato
Copy link
Member Author

JmPotato commented Jun 4, 2024

/check-dco

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit fcec188 into tikv:master Jun 4, 2024
18 of 20 checks passed
@JmPotato JmPotato deleted the log_join_error branch June 4, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants