Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/member: Fixing residual counts in campaign times #8226

Merged
merged 4 commits into from
May 30, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented May 30, 2024

What problem does this PR solve?

Issue Number: Close #8225

What is changed and how does it work?

  • Remove timeout times count
  • Make sure it's the current 5min judgment

Check List

Tests

  • Integration test

Release note

fixing residual counts in campaign times

Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested review from JmPotato and rleungx May 30, 2024 03:32
Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (52389b0) to head (86444c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8226      +/-   ##
==========================================
+ Coverage   77.26%   77.40%   +0.13%     
==========================================
  Files         470      470              
  Lines       61337    61337              
==========================================
+ Hits        47390    47475      +85     
+ Misses      10377    10298      -79     
+ Partials     3570     3564       -6     
Flag Coverage Δ
unittests 77.40% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 30, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2024
@HuSharp HuSharp added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 30, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/LGT1 Indicates that a PR has LGTM 1. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2024
Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Member Author

HuSharp commented May 30, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 30, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 86444c1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 71490f7 into tikv:master May 30, 2024
19 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8230.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request May 30, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8231.

@HuSharp HuSharp deleted the fix_campaignTimes branch May 30, 2024 08:49
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2024
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pd leader did not change after exec “/pd-ctl member leader transfer tc-pd-0”
5 participants