-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simulator: scale-in and scale out test for store-limit-version=v2
#8220
Conversation
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
Signed-off-by: bufferflies <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
simCase.Checker = func(regions *core.RegionsInfo, stats []info.StoreStats) bool { | ||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you wish to prevent the case from being exited?
…imit-v2 Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8220 +/- ##
==========================================
+ Coverage 77.10% 77.44% +0.33%
==========================================
Files 470 471 +1
Lines 61553 61394 -159
==========================================
+ Hits 47463 47548 +85
+ Misses 10506 10297 -209
+ Partials 3584 3549 -35
Flags with carried forward coverage won't be shown. Click here to find out more. |
cfg := h.GetScheduleConfig() | ||
if version := cfg.StoreLimitVersion; version != storelimit.VersionV1 { | ||
h.rd.JSON(w, http.StatusBadRequest, fmt.Sprintf("current store limit version:%s not support get limit", version)) | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do SetStoreLimitSceneand
GetStoreLimitScene` only need to support v2 as well?
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: lhy1024 <[email protected]>
What problem does this PR solve?
Issue Number: Ref #8135
renew #7792
What is changed and how does it work?
Check List
Tests
Release note