Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/statistics: reduce the memory alloc for hot statistics #8208

Merged
merged 1 commit into from
May 22, 2024

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 22, 2024

What problem does this PR solve?

Issue Number: Close #8207 Ref #7897

What is changed and how does it work?

relative smallnest/chanx#19

pkg/statistics: reduce the memory alloc for hot statistics

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    before:
go test -benchmem -run=^$ -bench ^BenchmarkUnbounded github.com/smallnest/chanx  
goos: darwin
goarch: arm64
pkg: github.com/smallnest/chanx
BenchmarkUnboundedChanLen-12            65669220                18.17 ns/op           32 B/op          1 allocs/op
BenchmarkUnboundedBufLen-12             69060109                18.27 ns/op           32 B/op          1 allocs/op

after

goos: darwin
goarch: arm64
pkg: github.com/smallnest/chanx
BenchmarkUnboundedChanLen-12            1000000000               0.2879 ns/op          0 B/op          0 allocs/op
BenchmarkUnboundedBufLen-12             1000000000               0.2846 ns/op          0 B/op          0 allocs/op

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx May 22, 2024 02:13
@nolouch nolouch removed the request for review from lhy1024 May 22, 2024 02:13
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2024
@nolouch nolouch requested review from JmPotato and lhy1024 May 22, 2024 02:13
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (0e73b7a) to head (1d52039).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8208      +/-   ##
==========================================
- Coverage   77.36%   77.33%   -0.04%     
==========================================
  Files         471      471              
  Lines       61407    61407              
==========================================
- Hits        47510    47491      -19     
- Misses      10340    10350      +10     
- Partials     3557     3566       +9     
Flag Coverage Δ
unittests 77.33% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2024
@rleungx
Copy link
Member

rleungx commented May 22, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 1d52039

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 43e9492 into tikv:master May 22, 2024
20 checks passed
@nolouch nolouch deleted the fix-chan-mem branch May 22, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce the memory alloc in hot statics
3 participants