Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/tso: organize the methods of TSO dispatcher #8121

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8047.

What is changed and how does it work?

Organize the methods of the TSO dispatcher.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Apr 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #8121 (32a7a7a) into master (fa7841b) will decrease coverage by 0.11%.
The diff coverage is 82.35%.

❗ Current head 32a7a7a differs from pull request most recent head 18b106d. Consider uploading reports for the commit 18b106d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8121      +/-   ##
==========================================
- Coverage   77.38%   77.27%   -0.11%     
==========================================
  Files         471      470       -1     
  Lines       61240    61145      -95     
==========================================
- Hits        47389    47249     -140     
- Misses      10280    10328      +48     
+ Partials     3571     3568       -3     
Flag Coverage Δ
unittests 77.27% <82.35%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -115,6 +86,17 @@ func (c *tsoClient) dispatchRequest(request *tsoRequest) (bool, error) {
return false, nil
}

func (c *tsoClient) closeTSODispatcher() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move the tsoClient-related function to tso_client.go?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, because all data structures are inside tsoClient, it is impossible to strictly distinguish them according to files. The organization logic here is to put as much dispatcher-related code as possible in tso_dispatcher.go, and then move some common methods to tso_client.go. Perhaps we can further abstract the data structure in the future and put all dispatcher-related logic into a separate structure.

@JmPotato JmPotato requested a review from rleungx April 23, 2024 08:48
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2024
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 24, 2024
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 32a7a7a

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

@JmPotato: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b4f292d into tikv:master Apr 24, 2024
22 checks passed
@JmPotato JmPotato deleted the sort_out_dispatcher branch April 24, 2024 08:22
nolouch pushed a commit to nolouch/pd that referenced this pull request Apr 29, 2024
ref tikv#8047

Organize the methods of the TSO dispatcher.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants