Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: allow client send consecutive pings in every 5 seconds #8120

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

yongman
Copy link
Contributor

@yongman yongman commented Apr 23, 2024

What problem does this PR solve?

Issue Number: Close #8119

What is changed and how does it work?

grpc: allow client send consecutive pings in every 5 seconds

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 23, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx April 23, 2024 07:43
@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Apr 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2024

Hi @yongman. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2024
@HuSharp
Copy link
Member

HuSharp commented Apr 23, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.25%. Comparing base (ca179e6) to head (43bd742).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8120   +/-   ##
=======================================
  Coverage   77.24%   77.25%           
=======================================
  Files         471      471           
  Lines       61696    61700    +4     
=======================================
+ Hits        47660    47669    +9     
+ Misses      10454    10450    -4     
+ Partials     3582     3581    -1     
Flag Coverage Δ
unittests 77.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@HuSharp
Copy link
Member

HuSharp commented Apr 24, 2024

/check-issue-triage-complete

@yongman
Copy link
Contributor Author

yongman commented Apr 25, 2024

@HuSharp PTAL

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 8, 2024
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jul 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

@yongman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 43bd742 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HuSharp
Copy link
Member

HuSharp commented Jul 16, 2024

/test pull-integration-realcluster-test

Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-08 07:46:01.828817064 +0000 UTC m=+257259.064051177: ☑️ agreed by nolouch.
  • 2024-07-16 09:38:55.636950249 +0000 UTC m=+346757.627891714: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit cbba49a into tikv:master Jul 16, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tso client receive GOAWAY when idle with keepalive
3 participants