Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make TestScheduler stable #8093

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 18, 2024

What problem does this PR solve?

Issue Number: Close #7062

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot requested review from HuSharp and lhy1024 April 18, 2024 08:21
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.28%. Comparing base (f83feba) to head (ce3a3f4).

❗ Current head ce3a3f4 differs from pull request most recent head aa6fbf6. Consider uploading reports for the commit aa6fbf6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8093      +/-   ##
==========================================
- Coverage   77.43%   77.28%   -0.16%     
==========================================
  Files         471      470       -1     
  Lines       61361    61129     -232     
==========================================
- Hits        47513    47241     -272     
- Misses      10281    10324      +43     
+ Partials     3567     3564       -3     
Flag Coverage Δ
unittests 77.28% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2024
@rleungx rleungx removed the require-LGT1 Indicates that the PR requires an LGTM. label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2024
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label May 7, 2024
@rleungx
Copy link
Member Author

rleungx commented May 7, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

This pull request has been accepted and is ready to merge.

Commit hash: ce3a3f4

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 7, 2024
Copy link
Contributor

ti-chi-bot bot commented May 7, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit b41c897 into tikv:master May 7, 2024
22 checks passed
@rleungx rleungx deleted the fix-test-2024-19 branch May 7, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdctl/TestScheduler is unstable
2 participants