Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make TestStores stable #8078

Merged
merged 2 commits into from
Apr 16, 2024
Merged

*: make TestStores stable #8078

merged 2 commits into from
Apr 16, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Apr 16, 2024

What problem does this PR solve?

Issue Number: Close #7954.

What is changed and how does it work?

The previously put region does not take effect since it doesn't update the store count.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx requested a review from HuSharp April 16, 2024 09:52
Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2024
@rleungx rleungx added require-LGT1 Indicates that the PR requires an LGTM. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2024
@rleungx
Copy link
Member Author

rleungx commented Apr 16, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 16, 2024

This pull request has been accepted and is ready to merge.

Commit hash: e1e2b18

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Merging #8078 (e1e2b18) into master (22543a9) will increase coverage by 0.03%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head e1e2b18 differs from pull request most recent head 7f851d6. Consider uploading reports for the commit 7f851d6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8078      +/-   ##
==========================================
+ Coverage   77.28%   77.32%   +0.03%     
==========================================
  Files         469      469              
  Lines       61097    61097              
==========================================
+ Hits        47218    47241      +23     
+ Misses      10325    10298      -27     
- Partials     3554     3558       +4     
Flag Coverage Δ
unittests 77.32% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 4c0a862 into tikv:master Apr 16, 2024
22 checks passed
@rleungx rleungx deleted the fix-test-2024-13 branch April 17, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestAPI/TestStores failed
2 participants