Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeTSAsync may be blocked #7864

Closed
CabinfeverB opened this issue Mar 1, 2024 · 1 comment · Fixed by #7862
Closed

GeTSAsync may be blocked #7864

CabinfeverB opened this issue Mar 1, 2024 · 1 comment · Fixed by #7862
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

Bug Report

What did you do?

Due to thathandleDispatcher will be canceled after closing, so

pd/client/tso_dispatcher.go

Line 86 in 2e3e4c0

dispatcher.(*tsoDispatcher).tsoBatchController.tsoRequestCh <- request

will be blocked.

see new test case in #7862

What did you expect to see?

What did you see instead?

What version of PD are you using (pd-server -V)?
@CabinfeverB CabinfeverB added type/bug The issue is confirmed as a bug. severity/minor labels Mar 1, 2024
@CabinfeverB
Copy link
Member Author

Because size of channel is large, so we can regard this as minor issue.

@CabinfeverB CabinfeverB mentioned this issue Mar 1, 2024
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #7862 Mar 1, 2024
ti-chi-bot bot added a commit that referenced this issue Mar 1, 2024
@CabinfeverB @HuSharp @ti-chi-bot
client: tsoRequest should return when in dispatching but context done (…
6cb8917 
…#7862)

close #7864

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: Hu# <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
Questions and Bug Reports
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

client: tsoRequest should return when in dispatching but context done CabinfeverB/pd
1 participant
@CabinfeverB